# 0041 — Approval — Module Triage

**Milestone:** M3
**Owner:** TBD
**Status:** planning

## Goal

Consolidates 7 legacy issues from the
`MetaDrivenPlatform4AI` repo that share the same module / area label,
so they can be triaged together by the corresponding domain IC.

Module label scope: `module/approval`.

## Acceptance criteria

- [ ] All `ported` children below have a Story or Bug filed in pingcap-pack
- [ ] All filed Stories / Bugs have a linked test (existing or to-write task with scaffold)
- [ ] Engineering review confirms which children are still applicable under the new project's design

## Stories / Bugs (filed as GitHub issues)

7 children classified `ported`. Phase 3/4 will file each as
a Story (capability) or Bug (defect) in this repo and back-reference the
legacy issue. Initial child list:

- [ ] #TBD — legacy MetaDrivenPlatform4AI#1336 — ApprovalProcessDetailPage.test.tsx fails on main: useSchema mock error
- [ ] #TBD — legacy MetaDrivenPlatform4AI#1729 — Approval Entry Criteria: multiple conditions on same field use AND instead of OR
- [ ] #TBD — legacy MetaDrivenPlatform4AI#1741 — Approval tab shows no pending records; approver must manually search and refresh to see approval
- [ ] #TBD — legacy MetaDrivenPlatform4AI#1911 — Sales users cannot see 'Submit for Approval' button due to missing ProcessDefinition read permission
- [ ] #TBD — legacy MetaDrivenPlatform4AI#2003 — [Approval Engine] Action execution — Ext#5 owner + RFC
- [ ] #TBD — legacy MetaDrivenPlatform4AI#2054 — Approval step ifCriteriaNotMet=GotoNextStep ignored: frontend parser drops the field; backend Submit skips first-step criteria
- [ ] #TBD — legacy MetaDrivenPlatform4AI#2056 — Approval banner shows Pending after final approval when skipped steps exist as Upcoming

## Non-goals

- Re-port legacy fixes that are no longer relevant under the new project's
  pure-platform design — engineering identifies these case-by-case
- Layer-belonging classification (L0 / L1 / L2) — engineering's job

## History

- 2026-05-03 — created during Phase 2 from clustered orphan issues.

## Stories (filed in Phase 3)

_Pending Phase 3 synthesis._