# PR 3462 Review Follow-ups

## Analysis

| Area | Files | Impact | Keep / Remove |
|------|-------|--------|---------------|
| PiTR restore cleanup action | `app/workflow/action/restore/pitr/create/delete_compaction.go` | Add reviewer-requested observability for the async compaction-delete DAG trigger without changing restore state semantics | Keep the sync-then-async split; add logging only |
| Workflow action formatting | `app/workflow/action/backup/compact/purge_compaction_storage.go` | Normalize formatting to repo conventions so CI/review noise is removed | Keep logic; remove formatting drift |
| Workflow action test formatting | `app/workflow/action/backup/compact/purge_compaction_storage_test.go` | Normalize formatting to repo conventions so CI/review noise is removed | Keep assertions and test coverage; remove formatting drift |
| Review thread handling | PR threads on #3462 | Resolve only comments that are addressed by code or are purely informational | Keep unresolved only if follow-up is still required |

### Dead Code / Cascade Check

- No dead-code removal is expected for this follow-up.
- Logging change must not alter `AsyncDelete` error handling or retry behavior.
- Formatting changes must stay limited to the touched workflow files.

## Execution Steps

1. Inspect open PR review threads and map each one to a concrete file or a no-code resolution path.
   - Verification: every unresolved thread is accounted for before editing.
2. Update `DeleteCompactionForPiTR` to log the async compaction-delete DAG instance/workflow id when the trigger succeeds.
   - Verification: code path still treats async trigger failure as non-fatal and logs `workflow_id` when present.
3. Reformat the workflow action files flagged by review.
   - Verification: `gofumpt` produces no further diffs for the targeted files.
4. Run the relevant repository verification for the Go changes.
   - Verification command: `make app-unit-test-local`
   - Success criteria: command exits 0.
5. Resolve the addressed PR review threads, including the informational summary thread if no code follow-up is needed.
   - Verification: no addressed thread remains unresolved.

## Risk Assessment

- **Low risk** for formatting-only updates.
- **Low-to-medium risk** for the restore action log change because it touches the PiTR cleanup path, but it is additive observability only and does not alter the sync/async deletion contract.
